Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix github action arm image built #948

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix github action arm image built #948

wants to merge 2 commits into from

Conversation

hzxuzhonghu
Copy link
Member

What type of PR is this?

What this PR does / why we need it:

: without this, though the docker image is ar,64 arch but the kmesh-daemon within it is just x86-64.

Which issue(s) this PR fixes:
Fixes #944

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hzxuzhonghu. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov Codecov
Copy link

codecov bot commented Oct 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.28%. Comparing base (739fde5) to head (6884bde).
Report is 13 commits behind head on main.

see 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b85ca41...6884bde. Read the comment docs.

LiZhenCheng9527
LiZhenCheng9527 reviewed Oct 12, 2024
View reviewed changes
build/docker/github.dockerfile
@@ -0,0 +1,26 @@
FROM ghcr.io/kmesh-net/kmesh-build:latest AS builder
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why need a new dockerfile?Why not modify the original dockerfile?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a temparary fix. Becase that @weli-l found before #742, it failed to build using docker 18.09

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@LiZhenCheng9527
Copy link
Collaborator

/lgtm

@kmesh-bot kmesh-bot added the lgtm label Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiZhenCheng9527 LiZhenCheng9527 LiZhenCheng9527 left review comments

@bitcoffeeiux bitcoffeeiux Awaiting requested review from bitcoffeeiux

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

At least 1 approving review is required to merge this pull request.

Assignees

@LiZhenCheng9527 LiZhenCheng9527

Labels
lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[release 0.5]Binary in Kmesh arm image not exec properly
3 participants
@hzxuzhonghu @kmesh-bot @LiZhenCheng9527